Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hardware section #3866

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: hardware section #3866

merged 1 commit into from
Oct 23, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Oct 23, 2024

Describe Your Changes

  • Wrong logic, hidden dropdown only

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Oct 23, 2024
@urmauur urmauur added this to the v0.5.7 milestone Oct 23, 2024
@urmauur urmauur self-assigned this Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 69.51%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/screens/Settings/Advanced/index.tsx78, 91, 108-111, 121, 125-127, 129, 177, 193-196, 198-199, 201, 205-206, 208, 210-211, 255, 287-290, 296-298, 305, 335, 357, 366, 415, 489, 494

louis-jan
louis-jan approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit 9a266db into dev Oct 23, 2024
12 checks passed
@urmauur urmauur deleted the fix/hardware-section branch October 23, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@urmauur urmauur

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.5.7
Development

Successfully merging this pull request may close these issues.
2 participants
@urmauur @louis-jan